This is where I'm going with fwcontrol
Sean Bruno
sbruno at miralink.com
Tue Aug 12 01:07:30 UTC 2008
Dieter wrote:
>> Also, I changed some of the variable to check for >= 0 and set their
>> default values to -1. This should have the same effect as adding a new
>> variable as you did in your fix.
>>
>
> If you're going to do it that way, the code should check that the argument
> is in range, and print a complaint if out of range. Otherwise the user could
> say "fwcontrol -f -1" and nothing would happen. And the man page should list
> the legal range. Hmmm, actually these should be done even with the
> add-a-new-variable method.
>
Excellent feedback, let me work on something tonight and reissue the patch.
--
Sean Bruno
MiraLink Corporation
6015 NE 80th Ave, Ste 100
Portland, OR 97218
Cell 503-358-6832
Phone 503-621-5143
Fax 503-621-5199
MSN: sbruno at miralink.com
Google: seanwbruno at gmail.com
More information about the freebsd-firewire
mailing list