This is where I'm going with fwcontrol

Dieter freebsd at sopwith.solgatos.com
Tue Aug 12 00:34:37 UTC 2008


> Also, I changed some of the variable to check for >= 0 and set their 
> default values to -1.  This should have the same effect as adding a new 
> variable as you did in your fix.

If you're going to do it that way, the code should check that the argument
is in range, and print a complaint if out of range.  Otherwise the user could
say "fwcontrol -f -1" and nothing would happen.  And the man page should list
the legal range.  Hmmm, actually these should be done even with the
add-a-new-variable method.


More information about the freebsd-firewire mailing list