Bug: CVSweb 3.0.4

VilleSkyttä scop at FreeBSD.org
Sat Jan 8 09:07:13 PST 2005


On Fri, 2005-01-07 at 09:20 +0100, Vlado Klimovsky wrote:
> Hello,
> 
> there seems to be a bug in the 3.0.4 version of the CVSweb script. Please
> see the spacedHtmlText() function, line 1585, which reads:
> 
>   1 while s/(.*)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;
> 
> The problem is in the '(.*)' subexpression; by default the '*' match
> specifier is greedy so the regular expression '(\t+)' will match the LAST
> sequence of tabs on the string, not the first one. For this reason the tabs
> are expanded into an incorrect number of spaces. I changed the line like
> this:
> 
>   1 while s/(.*?)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;
> 
> and the problem seems to be solved.

Applied, this will be in 3.0.5.  Thanks!



More information about the freebsd-cvsweb mailing list