Bug: CVSweb 3.0.4

[Vlado Klimovsky]

Hello,

there seems to be a bug in the 3.0.4 version of the CVSweb script. Please
see the spacedHtmlText() function, line 1585, which reads:

  1 while s/(.*)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;

The problem is in the '(.*)' subexpression; by default the '*' match
specifier is greedy so the regular expression '(\t+)' will match the LAST
sequence of tabs on the string, not the first one. For this reason the tabs
are expanded into an incorrect number of spaces. I changed the line like
this:

  1 while s/(.*?)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;

and the problem seems to be solved.

Regards,
Vlado Klimovsky


------------------------------------------------
Vladimir KLIMOVSKY (klimovsky at iblsoft.com)
IBL Software Engineering, http://www.iblsoft.com/
Mierova 103, 82105 Bratislava, Slovakia
Tel: +421 2 4342 7459, fax: +421 2 4342 7214
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3032 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-cvsweb/attachments/20050107/9e373ee4/smime.bin