IPFilter build failure

[Darren Reed]

Max Laier wrote:
> On Monday 04 August 2008 21:27:22 Beech Rintoul wrote:
> > I've been getting the following trying to build current. I
> > nuked /usr/obj and have downloaded fresh sources:
> >
> > ipftest/../../../contrib/ipfilter
> > -I/usr/src/sbin/ipf/ipftest/../../../contrib/ipfilter/tools
> > -I/usr/src/sbin/ipf/ipftest/../../../sys
> > -I/usr/src/sbin/ipf/ipftest/../../../sys/contrib/ipfilter -DSTATETOP
> > -D__UIO_EXPOSE -fstack-protector -Wno-pointer-sign  -static -o ipftest
> > ipftest.o fil.o ip_frag.o ip_state.o ip_nat.o ip_proxy.o
> > ip_auth.o ip_htable.o ip_lookup.o ip_pool.o ip_scan.o ip_sync.o
> > ip_rules.o ip_fil.o ip_log.o ippool_y.o ippool_l.o ipf_y.o ipf_l.o
> > ipnat_y.o ipnat_l.o md5.o radix.o
> > bpf_filter.o /usr/obj/usr/src/sbin/ipf/ipftest/../libipf/libipf.a -lkvm
> > /usr/obj/usr/src/tmp/usr/lib/libc.a(arc4random.o)(.text+0x240): In
> >
> > function `arc4random':
> > : multiple definition of `arc4random'
> >
> > ip_fil.o(.text+0x80): first defined here
> > /usr/obj/usr/src/tmp/usr/bin/ld: Warning: size of symbol `arc4random'
> > changed from 43 in ip_fil.o to 421
> > in /usr/obj/usr/src/tmp/usr/lib/libc.a(arc4random.o)
> > *** Error code 1
> >
> > uname -a:
> > FreeBSD stargate.alaskaparadise.com 8.0-CURRENT FreeBSD 8.0-CURRENT
> > #31: Sun Jul 27 02:48:49 AKDT 2008
> >
> > Anyone have a clue how to fix this?
>
> Please test the attached ... sent it to a similar report in cvs@ a few days 
> back, but did not get any feedback.  Are you using WITHOUT_DYNAMICROOT?
>   

Apologies for letting this slip, my attention has been elsewhere and
thanks for committing the fix.

This problem didn't showup when I was compiling, so I'll double
check what's been committed is correct.

It turned out that I didn't want arc4random used at all in ipftest,
so I need to get in there and try and sort out that mess, but it
got carried over as part of the "generic set of changes."

Darren
(yes, I hate the #Ifdef mess too...blah)