Panic on -CURRENT after LDT changes

Attilio Rao attilio at FreeBSD.org
Mon May 28 21:06:39 UTC 2007


Tor Egge wrote:
> 
> Finally, I found that i386_ldt_grow() called smp_rendezvous() without
> temporarily unlocking dt_lock.  That caused a deadlock.  Adding a temporary
> unlock of dt_lock seems to solve the problem for me.

Effectively, there is the need to release the dt_lock before to call 
smp_rendezvous() beacause other threads running on other CPUs will 
contest on this lock and it will cause a deadlock (since their 
curthreads don't hold the lock).
I think that mantaining the current locking requirements for 
i386_ldt_grow() is still good, since, for how it is used, this is the 
lighter approach. I will add release/unrelease around smp_rendezvous() too.

Thanks for the catch,
Attilio



More information about the freebsd-current mailing list