HEADS DOWN (was Re: HEADS UP: putenv, setenv, unsetenv, getenv changes)

Brooks Davis brooks at freebsd.org
Wed May 2 15:57:32 UTC 2007


On Tue, May 01, 2007 at 08:06:45PM +0400, Andrey Chernov wrote:
> All backed out.
> 
> Not because I admit they are technically wrong and not because of bug
> reports (I receive nothing). But because I surprisingly meets so
> strong opposition and resistance so lost any desire to continue that.
> 
> Anyone who interested in POSIX can dig out what changes and how
> through cvs diffs.

FreeBSD does care about standards and your change probably makes sense,
but the way you went about it was all wrong.

First, you committed an API/ABI change to libc without even performing
a buildworld.  You should be commended for fixing the problems quickly,
but the breakage rightfully made people nervous.

Second and more importantly, you committed an API/ABI change to libc
without any discussion beforehand.  Had you done so, this almost
certainly would have gone smootly.

Third, your waving of the POSIX flag when people responded negativly did
not help.  While following POSIX is generally a good idea, blindly doing
so is not.  Given that *env() is a lousy API by any reasonable measure,
sounder arguments such as those raised by jhb were needed.

I hope you will engage in productive disussion of this change and should
it be accepted (and I think it will) commit it again.

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20070502/1781a197/attachment.pgp


More information about the freebsd-current mailing list