crash in tty code in 6.1.. fixed since?

Julian Elischer julian at elischer.org
Fri Jul 13 18:43:00 UTC 2007


>>> tp_session is NULL but it shouldn't have been able to have run that line 
>>> (line 1659) if it had tested NULL 2 lines before..
>>> this suggests a locking problem..
>> I think it has been fixed some months ago IIRC.
>> The problem here, should be that if sx_slock() let thread sleep, Giant 
>> is released before to sleep and tp->t_session can be accessed in racy way.
>> Another nice side-effect about having tty Giant :)
> 
> Yes, it seems that rev. 1.267 fixed it and was MFCed as rev. 1.228.2.6.
> There was a lot of commits around this one, it may be safer to update to
> RELENG_6.

That's not an option on a product. 
6.1 has passed all sorts of QA benchmarks etc. and while we will upgrade,
it will probably happen next year.


More information about the freebsd-current mailing list