D_NEEDGIANT usage in {amd64,i386}/isa/clock.c

[Ed Schouten]

Hello,

I was just taking a look at the /dev/nvram code in the isa/clock.c files
of the amd64 and i386 architectures. For some reason, the "nvram" device
needs D_NEEDGIANT. If I take a look at the nvram_open(), nvram_read()
and nvram_write() routines, I see no reason why it should be marked
D_NEEDGIANT.

Both the nvram_read() and nvram_write() routines both perform some
simple bounds checking and then call rtcin() and writertc(). Both of
those routines are already protected from concurrent access through the
RTC_LOCK and RTC_UNLOCK macro's.

Yours,
-- 
 Ed Schouten <ed at fxq.nl>
 WWW: http://g-rave.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20070710/9b1915c3/attachment.pgp