ufsstat - testers / feedback wanted!

[Poul-Henning Kamp]

In message <434FDB70.5040701 at centtech.com>, Eric Anderson writes:
>Poul-Henning Kamp wrote:

>>>From what it sounds like, you'd also like to see per-mount point stats, 
>>>but from the vfs layer, right?   If that's true, then do you have any 
>>>suggestions on how to store the statistics for each mounted fs?
>> 
>> 
>> In struct mount ?
>
>Ok - so I'd place my struct vfsstats in the mount struct, so each fs 
>records it's own stats if the mount option is enabled.  (reiterating to 
>make sure I'm understanding correctly)

Or, depending if this is easier, have the VOP_FOO() functions increment
the stats if the mountpoint flag is set.

>Also - is it best to increment the counters at the beginning of the 
>operation, end, or something else?

The only difference is that at the end you can also record the
return code and make a counter for "failure" if you want.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.