Locking for ef(4)

Wojciech A. Koszek dunstan at freebsd.czest.pl
Mon Aug 22 21:17:14 GMT 2005


On Mon, Aug 22, 2005 at 04:00:06PM -0400, John Baldwin wrote:
> On Saturday 20 August 2005 03:26 pm, Wojciech A. Koszek wrote:
> > Hello,
[..]
> 
> You might want to consider using MTX_SYSINIT() to initialize your mutex 
> instead of manually doing it in your module handler routine.  Either that or 
> go ahead and push the calls to mtx_init() and mtx_destroy() into ef_load() 
> and ef_unload() so all the load stuff happens in one function, etc.

I've moved mtx_init and mtx_destroy to ef_load() and ef_unload().
 
> Might also want to check for whitespace breakage in your diffs.  In 
> ef_detach() you replaced the empty line before ether_ifdetach() with a line 
> that contains just a tab.

Fixed. I've also removed also other place with redundant tabs.

Updated patch:
http://freebsd.czest.pl/dunstan/FreeBSD/diff.1.locking.if_ef.c

Thanks!

-- 
* Wojciech A. Koszek && dunstan at FreeBSD.czest.pl


More information about the freebsd-current mailing list