Detaching USB stick crashes BETA4/BETA5

Vladimir Grebenschikov vova at fbsd.ru
Thu Sep 23 22:36:29 PDT 2004


В вт, 21/09/2004 в 18:36 -0600, M. Warner Losh пишет:

> Ian Dowse also is having problems in this area.  He suggested the
> following patch to me.  I have some concerns about the patch, but they
> are theoretical (what does it mean when a parent is detached, but all
> its children are attached?), but given the current state of the newbus
> code it will fix the problem for you.

Yes, it fix my problem with usb unplug too on recent CURRENT.
Please commit.

> Warner
> 
> Index: usb_port.h
> ===================================================================
> RCS file: /dump/FreeBSD-CVS/src/sys/dev/usb/usb_port.h,v
> retrieving revision 1.67
> diff -u -r1.67 usb_port.h
> --- usb_port.h	15 Aug 2004 23:39:18 -0000	1.67
> +++ usb_port.h	21 Sep 2004 23:46:27 -0000
> @@ -422,6 +422,7 @@
>  #define config_detach(dev, flag) \
>  	do { \
>  		free(device_get_ivars(dev), M_USB); \
> +		device_detach(dev); \
>  		device_delete_child(device_get_parent(dev), dev); \
>  	} while (0);
>  

-- 
Vladimir B. Grebenchikov
vova at fbsd.ru


More information about the freebsd-current mailing list