patch: selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked

[John Baldwin]

On Saturday 18 September 2004 11:19 am, Rostislav Krasny wrote:
> > uname -a
>
> FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27
> IDT 2004     root at localhost:/usr/obj/usr/src/sys/GENERIC  i386
>
> Hi,
>
> When one select "All" on some of the "Distributions" menus of
> sysinstall(8) no distribution is marked but actually all of them are
> selected for installation. It can confuse one during a new system
> installation. Following patch fixes this problem:
>
> --- dist.c.prev Sat Sep 18 17:37:01 2004
> +++ dist.c      Sat Sep 18 17:38:06 2004
> @@ -291,7 +291,7 @@
>      XOrgDists = DIST_XORG_ALL;
>      i = distMaybeSetPorts(self);
>      distVerifyFlags();
> -    return i;
> +    return i | DITEM_REDRAW;
>  }
>
>  static int
>
>
> If you want test this patch on installed system try following scenario
> before and after applying it to your source:
>
> 1. run 'sysinstall' as a root
> 2. go to "Custom | Distributions" or to "Custom | Distributions |
> Custom" menu
> 3. select "All" on the menu and see what distributions are marked after
> that
>
> P.S. If this patch is correct it should be commited to 5.3 before the
> release, IMHO.

Committed to HEAD.  I'll put it in 5.3 if re@ oks it.  Thanks!

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org