patch: selecting "All" on some of sysinstall(8) menus doesn't make any distribution marked

Rostislav Krasny rosti_bsd at
Sat Sep 18 08:19:27 PDT 2004

> uname -a
FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27
IDT 2004     root at localhost:/usr/obj/usr/src/sys/GENERIC  i386


When one select "All" on some of the "Distributions" menus of
sysinstall(8) no distribution is marked but actually all of them are
selected for installation. It can confuse one during a new system
installation. Following patch fixes this problem:

--- dist.c.prev Sat Sep 18 17:37:01 2004
+++ dist.c      Sat Sep 18 17:38:06 2004
@@ -291,7 +291,7 @@
     XOrgDists = DIST_XORG_ALL;
     i = distMaybeSetPorts(self);
-    return i;
+    return i | DITEM_REDRAW;

 static int

If you want test this patch on installed system try following scenario
before and after applying it to your source:

1. run 'sysinstall' as a root
2. go to "Custom | Distributions" or to "Custom | Distributions |
Custom" menu
3. select "All" on the menu and see what distributions are marked after

P.S. If this patch is correct it should be commited to 5.3 before the
release, IMHO.

Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage! 

More information about the freebsd-current mailing list