Re2: Possible bug in softclock()

Matthew Dillon dillon at apollo.backplane.com
Mon Sep 13 22:21:15 PDT 2004


    oops... no , forget... it's correct.  I got the sense reversed.

					-Matt
					Matthew Dillon 
					<dillon at backplane.com>

:
:    In softclock(), should this line:
:
:	c->c_flags = (c->c_flags & ~CALLOUT_PENDING);
:
:    be:
:
:	c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE));
:
:    ?
:
:    Otherwise routines which call callout_reset() to reset the callout
:    will always clear the CALLOUT_MPSAFE flag.  This won't hurt things,
:    but it will make them more inefficient.



More information about the freebsd-current mailing list