Possible bug in softclock()

Matthew Dillon dillon at apollo.backplane.com
Mon Sep 13 22:09:43 PDT 2004


    In softclock(), should this line:

	c->c_flags = (c->c_flags & ~CALLOUT_PENDING);

    be:

	c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE));

    ?

    Otherwise routines which call callout_reset() to reset the callout
    will always clear the CALLOUT_MPSAFE flag.  This won't hurt things,
    but it will make them more inefficient.

					-Matt
					Matthew Dillon 
					<dillon at backplane.com>


More information about the freebsd-current mailing list