[Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823

--- Comment #2 from Christian Heckendorf <heckendorfc at gmail.com> ---
This patch may very well be wrong since I have no knowledge of UFS internals
but I assumed since these variables were being compared that the values were
compatible (the value of sblock.fs_ipg able to fit in a data type the size of
cgp->cg_old_niblk).

I don't see how comparing int16_t to uint32_t can be right :) Would you prefer
to cast cgp->cg_old_niblk to uint32_t? As far as I could tell with a brief look
at their source, OpenBSD doesn't even compare these variables.

-- 
You are receiving this mail because:
You are the assignee for the bug.