[Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823

Konstantin Belousov <kib at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kib at FreeBSD.org,
                   |                            |mckusick at mckusick.com

--- Comment #1 from Konstantin Belousov <kib at FreeBSD.org> ---
I do not see how this patch can be right.  You strip off high 16 bits from the
superblock' fs_ipg value and then compare truncated value to UFS1' niblk
cylgroup value.  This is plain wrong.

For UFS1, fs_ipg must be less than 2^15, so the values fit.

I have no idea what OpenBSD does there, but this is not how FreeBSD UFS
operates.  I suspect that binary layout of superblock or cg header on OpenBSD
is different.

-- 
You are receiving this mail because:
You are the assignee for the bug.