[Bug 210707] freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious condition

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210707

            Bug ID: 210707
           Summary: freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious
                    condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

1.

freebsd/sys/dev/aacraid/aacraid.c:2854]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error = copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t)) != 0))
        goto out;

Maybe better code

    if ((error = copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t))) != 0)
        goto out;

2.

freebsd/sys/dev/aacraid/aacraid.c:2861]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error = copyin((void *)user_srb, srbcmd, fibsize) != 0))

Maybe better code

    if ((error = copyin((void *)user_srb, srbcmd, fibsize)) != 0)

-- 
You are receiving this mail because:
You are the assignee for the bug.