[Bug 210706] freebsd/sys/boot/efi/boot1/boot1.c:631]: (style) Suspicious condition

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Jun 29 19:34:30 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210706

            Bug ID: 210706
           Summary: freebsd/sys/boot/efi/boot1/boot1.c:631]: (style)
                    Suspicious condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

freebsd/sys/boot/efi/boot1/boot1.c:631]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

Source code is

        if ((status = bs->AllocatePool(EfiLoaderData, hsize,
            (void **)&handles) != EFI_SUCCESS)) {

Maybe better code

        if ((status = bs->AllocatePool(EfiLoaderData, hsize,
            (void **)&handles)) != EFI_SUCCESS) {

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list