misc/186006: buildworld libc build error "'MALLOC_PRODUCTION' macro redefined [-Werror]" in 10.0-RELEASE in jemalloc_jemalloc.c

[John Howie]

The following reply was made to PR misc/186006; it has been noted by GNATS.

From: John Howie <john at thehowies.com>
To: "bug-followup at FreeBSD.org" <bug-followup at FreeBSD.org>, John Howie
	<john at thehowies.com>
Cc:  
Subject: Re: misc/186006: buildworld libc build error
 "'MALLOC_PRODUCTION' macro redefined [-Werror]" in
 10.0-RELEASE in jemalloc_jemalloc.c
Date: Tue, 28 Jan 2014 06:36:16 +0000

 Did some digging and found the problem. The build script for ARM has the
 following line:
 
 make -C $SRCROOT MALLOC_PRODUCTION=3Dyes buildworld
 
 In the file contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h the
 following lines exist:
 
 #define MALLOC_PRODUCTION
 
 #ifndef MALLOC_PRODUCTION
 #define JEMALLOC_DEBUG
 #endif
 
 The bug is therefor not limited to the ARM processor build of
 10.0-RELEASE. Recommendation is to remove the definition of
 MALLOC_PRODUCTION from the header file, and document MALLOC_PRODUCTION
 properly (it is referenced in
 https://wiki.freebsd.org/DefaultDebuggingKnobs and a few other places).
 
 Regards,
 
 John