kern/184092: zfs zvol devices are not appearing till after reimport of pool
Christopher Harrison
harrison at glsan.com
Mon Jan 27 20:30:01 UTC 2014
The following reply was made to PR kern/184092; it has been noted by GNATS.
From: Christopher Harrison <harrison at glsan.com>
To: d at delphij.net, freebsd-gnats-submit at FreeBSD.org
Cc: Andriy Gapon <avg at freebsd.org>
Subject: Re: kern/184092: zfs zvol devices are not appearing till after reimport
of pool
Date: Mon, 27 Jan 2014 14:29:07 -0600
This is a multi-part message in MIME format.
--------------030209090805040302020101
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
I was not able to get the code patch to apply cleanly. I do support
the idea of a devfs hook. I think the devfs hook is a lot cleaner and
reduces the need to make sure the devnode is created/destroyed after
every update to the zvols.
-C
On 11/19/13 12:50, Xin Li wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> I think Andriy (cc'ed) have fixed a similar issue. A quick glance at
> the code suggests maybe we can use something like this:
>
>
> Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
> ===================================================================
> - --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
> (revision 258350)
> +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
> (working copy)
> @@ -3298,6 +3298,10 @@ zfs_ioc_clone(const char *fsname, nvlist_t *innvl,
> if (error != 0)
> (void) dsl_destroy_head(fsname);
> }
> +#ifdef __FreeBSD__
> + if (error == 0)
> + zvol_create_minors(fsname);
> +#endif
> return (error);
> }
>
> Can you confirm if this helps?
>
> (I think we should use a better way to trigger zvol_create_minor,
> maybe via a devfs lookup hook?)
>
> Cheers,
> -----BEGIN PGP SIGNATURE-----
>
> iQIcBAEBCgAGBQJSi7L6AAoJEJW2GBstM+nsU7IQAKJhuls5BEXXsvp8SsoJDZ1x
> 7SK4BP27cIF++hqzf4DVyP5OJEXFivFBgmbbdcS2q91X4ZR7kwdp/c7PWLArrtLO
> uQkQaeFpr5xvZsro6n58zVqjFc6ItaEZ0RWsv82Rqx9lVX8INb3Z/AneM2HXVXkX
> GDPTCf17bsxcgsxeCXgirpYYO4bOnUlTCNNmBSR62BNvQRNHwrTO+wVRVLGkZ4JK
> /y0GtiE2P1xhGq24XNswGqlmZPwBZHvqrvMXM1BjAdW2/kKuzWQ2HA9nflSGFK5k
> V502qe+fZXK4p227/9To1XfNIDC2GnONfvYOjqJigwjvd+2zENVxyLphHowfQpkw
> qWOgQ7b8nHc5GzjkWRJIJVm1JJHSHfAyH3VRwHBkEOGv0qs/ScM3x9mjaeqSb5Uu
> cIAF2vMt9gDfvgsV1fL0y33qOGFMFqPW7E0oOPGHrDMRQPUsGAeItUWCppbxmnVD
> HkCbPxYiH3EoFXULT8kX5gthRpbl1IveEluGGFITPxYsj1XmUvmQPBSkJPauoTvZ
> 0Aoe306mfuad8gmCBxpSCqTs9cvQrzeOvfc3bMKSLmSCbZ7SfnwG1EVGUMiX1DI9
> 1ugyRXHPlCZ/59HsEDym+Jlz/cqijo+dFykgjllwiwQtgzQSAhlaiyXjVZIxhfKL
> EgIpjuU+stDV10DsEwow
> =jwi6
> -----END PGP SIGNATURE-----
--------------030209090805040302020101
Content-Type: text/x-vcard; charset=utf-8;
name="harrison.vcf"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="harrison.vcf"
begin:vcard
fn:Christopher Harrison
n:Harrison;Christopher
org:Great Lakes SAN, LLC
adr;dom:;;518 Holly Ave;Madison;Wi;53711
email;internet:harrison at glsan.com
title:CEO
tel;work:608.347.6967
version:2.1
end:vcard
--------------030209090805040302020101--
More information about the freebsd-bugs
mailing list