misc/181931: vlan over lagg over mlxen crashes the kernel

[Shahar Klein]

>Number:         181931
>Category:       misc
>Synopsis:       vlan over lagg over mlxen crashes the kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 08 10:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Shahar Klein
>Release:        9.1
>Organization:
Mellanox
>Environment:
FreeBSD 9.1-RELEASE FreeBSD 9.1-RELEASE root at farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:

Creating a vlan over lagg over mlxen crashes the kernel
>How-To-Repeat:

ifconfig lagg0 create
ifconfig lagg0 laggport mlxen0 laggport mlxen1
ifconfig lagg0.400 create
>Fix:
seems like a sanity test is needed entering the rx_vlan handler

--- a/sys/ofed/drivers/net/mlx4/en_netdev.c
+++ b/sys/ofed/drivers/net/mlx4/en_netdev.c
@@ -51,6 +51,9 @@ static void mlx4_en_vlan_rx_add_vid(void *arg, struct net_device *dev, u16 vid)
        int idx;
        u8 field;

+        if (arg != priv)
+                return;
+
        if ((vid == 0) || (vid > 4095))    /* Invalid */
                return;
        en_dbg(HW, priv, "adding VLAN:%d\n", vid);
@@ -72,6 +75,9 @@ static void mlx4_en_vlan_rx_kill_vid(void *arg, struct net_device *dev, u16 vid)
        int idx;
        u8 field;

+        if (arg != priv)
+                return;
+
        if ((vid == 0) || (vid > 4095))    /* Invalid */
                return;
        en_dbg(HW, priv, "Killing VID:%d\n", vid);


>Release-Note:
>Audit-Trail:
>Unformatted: