kern/172166: commit references a PR

[dfilter service]

The following reply was made to PR kern/172166; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/172166: commit references a PR
Date: Mon, 25 Mar 2013 14:30:42 +0000 (UTC)

 Author: melifaro
 Date: Mon Mar 25 14:30:34 2013
 New Revision: 248705
 URL: http://svnweb.freebsd.org/changeset/base/248705
 
 Log:
   Unlock IPMI sc while performing requests via KCS and SMIC interfaces.
   It is already done in SSIF interface code.
   This reduces contention/spinning reported by many users.
   
   PR:		kern/172166
   Submitted by:	Eric van Gyzen <eric at vangyzen.net>
   MFC after:	2 weeks
 
 Modified:
   head/sys/dev/ipmi/ipmi_kcs.c
   head/sys/dev/ipmi/ipmi_smic.c
 
 Modified: head/sys/dev/ipmi/ipmi_kcs.c
 ==============================================================================
 --- head/sys/dev/ipmi/ipmi_kcs.c	Mon Mar 25 13:58:17 2013	(r248704)
 +++ head/sys/dev/ipmi/ipmi_kcs.c	Mon Mar 25 14:30:34 2013	(r248705)
 @@ -456,6 +456,7 @@ kcs_loop(void *arg)
  
  	IPMI_LOCK(sc);
  	while ((req = ipmi_dequeue_request(sc)) != NULL) {
 +		IPMI_UNLOCK(sc);
  		ok = 0;
  		for (i = 0; i < 3 && !ok; i++)
  			ok = kcs_polled_request(sc, req);
 @@ -463,6 +464,7 @@ kcs_loop(void *arg)
  			req->ir_error = 0;
  		else
  			req->ir_error = EIO;
 +		IPMI_LOCK(sc);
  		ipmi_complete_request(sc, req);
  	}
  	IPMI_UNLOCK(sc);
 
 Modified: head/sys/dev/ipmi/ipmi_smic.c
 ==============================================================================
 --- head/sys/dev/ipmi/ipmi_smic.c	Mon Mar 25 13:58:17 2013	(r248704)
 +++ head/sys/dev/ipmi/ipmi_smic.c	Mon Mar 25 14:30:34 2013	(r248705)
 @@ -362,6 +362,7 @@ smic_loop(void *arg)
  
  	IPMI_LOCK(sc);
  	while ((req = ipmi_dequeue_request(sc)) != NULL) {
 +		IPMI_UNLOCK(sc);
  		ok = 0;
  		for (i = 0; i < 3 && !ok; i++)
  			ok = smic_polled_request(sc, req);
 @@ -369,6 +370,7 @@ smic_loop(void *arg)
  			req->ir_error = 0;
  		else
  			req->ir_error = EIO;
 +		IPMI_LOCK(sc);
  		ipmi_complete_request(sc, req);
  	}
  	IPMI_UNLOCK(sc);
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"