bin/113518: [patch] make(1): Prevent execution when command is a comment

[Eitan Adler]

The following reply was made to PR bin/113518; it has been noted by GNATS.

From: Eitan Adler <lists at eitanadler.com>
To: Jilles Tjoelker <jilles at stack.nl>, sjg at freebsd.org
Cc: bug-followup at freebsd.org
Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a comment
Date: Sun, 4 Nov 2012 07:35:01 -0500

 On 4 November 2012 07:20, Jilles Tjoelker <jilles at stack.nl> wrote:
 > The following reply was made to PR bin/113518; it has been noted by GNATS.
 >
 > From: Jilles Tjoelker <jilles at stack.nl>
 > To: bug-followup at FreeBSD.org, ed at fxq.nl
 > Cc: sjg at FreeBSD.org
 > Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a
 >  comment
 > Date: Sun, 4 Nov 2012 13:11:58 +0100
 >
 >  In PR bin/113518:
 >  > [patch to teach make about the shell's comment character]
 >
 >  The first thing here is whether there are actually real-life Makefiles
 >  containing shell commands consisting only of comments. I only find a
 >  few in /usr/ports/Mk:
 >
 >  jilles at jaguar /usr/ports/Mk% grep $'^[ \t]\\+#' *
 >  bsd.gecko.mk:   # XXX: make sure bsdtar(1) corrected symlinks
 >  bsd.kde4.mk:  # Check that the component is valid.
 >  bsd.kde4.mk:   # Skip meta-components (e.g., kdeprefix).
 >  bsd.kde4.mk:    # Check if a dependency type is explicitly requested.
 >  bsd.kde4.mk:    # If no dependency type is set, default to full dependency.
 >  bsd.kde4.mk:    # Set real dependencies.
 
 [10017 eitan at radar /usr/ports !130!]%find . -name Makefile\*|xargs
 grep $'^[ \t]\\+#'|wc -l
      420
 
 >  Secondly, I don't think such new features should be added to make(1)
 >  when it is planned to replace it with bmake (sjg@ cc'ed). Also, bmake
 >  generally knows less about the shell than make(1) does so it does not
 >  seem to fit in to add it to bmake.
 
 Shall this bug be closed?
 
 
 -- 
 Eitan Adler