bin/113518: [patch] make(1): Prevent execution when command is a comment

Jilles Tjoelker jilles at
Sun Nov 4 12:20:02 UTC 2012

The following reply was made to PR bin/113518; it has been noted by GNATS.

From: Jilles Tjoelker <jilles at>
To: bug-followup at, ed at
Cc: sjg at
Subject: Re: bin/113518: [patch] make(1): Prevent execution when command is a
Date: Sun, 4 Nov 2012 13:11:58 +0100

 In PR bin/113518:
 > [patch to teach make about the shell's comment character]
 The first thing here is whether there are actually real-life Makefiles
 containing shell commands consisting only of comments. I only find a
 few in /usr/ports/Mk:
 jilles at jaguar /usr/ports/Mk% grep $'^[ \t]\\+#' *   # XXX: make sure bsdtar(1) corrected symlinks  # Check that the component is valid.   # Skip meta-components (e.g., kdeprefix).    # Check if a dependency type is explicitly requested.    # If no dependency type is set, default to full dependency.    # Set real dependencies.
 Likewise, there are only very few in src/**/Makefile* .
 It is unlikely that skipping the shell for these will give significant
 performance benefits.
 Secondly, I don't think such new features should be added to make(1)
 when it is planned to replace it with bmake (sjg@ cc'ed). Also, bmake
 generally knows less about the shell than make(1) does so it does not
 seem to fit in to add it to bmake.
 Jilles Tjoelker

More information about the freebsd-bugs mailing list