bin/154310: xz crashes on ARM

[Michael Moll]

>Number:         154310
>Category:       bin
>Synopsis:       xz crashes on ARM
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 26 17:10:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Michael Moll
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD deskstar.kvedulv.de 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r217665: Sat Jan 22 20:15:50 CET 2011     mmoll at emperor.kvedulv.de:/usr/obj/arm.arm/usr/current/src/sys/DESKSTAR  arm

>Description:
xz crashes on ARM (maybe also on other platforms).
>How-To-Repeat:

>Fix:
The attached patch implements an idea from http://lists.freebsd.org/pipermail/freebsd-arm/2010-September/002570.html and is not ARM specific.

Patch attached with submission follows:

Index: lib/liblzma/config.h
===================================================================
--- lib/liblzma/config.h	(revision 217884)
+++ lib/liblzma/config.h	(working copy)
@@ -66,7 +66,6 @@
 #define SIZEOF_SIZE_T 8
 #define STDC_HEADERS 1
 #define TUKLIB_CPUCORES_SYSCTL 1
-#define TUKLIB_FAST_UNALIGNED_ACCESS 1
 #define TUKLIB_PHYSMEM_SYSCONF 1
 #ifndef _ALL_SOURCE
 # define _ALL_SOURCE 1
@@ -86,6 +85,10 @@
 #define VERSION "5.0.0"
 #if defined(__FreeBSD__)
 #include <machine/endian.h>
+#include <machine/_types.h>
+#if __NO_STRICT_ALIGNMENT
+#define TUKLIB_FAST_UNALIGNED_ACCESS 1
+#endif
 #if _BYTE_ORDER == _BIG_ENDIAN
 # define WORDS_BIGENDIAN 1
 #endif


>Release-Note:
>Audit-Trail:
>Unformatted: