bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR environment variable to a location with at least 0 bytes

[Garrett Cooper]

The following reply was made to PR bin/121165; it has been noted by GNATS.

From: Garrett Cooper <yanegomi at gmail.com>
To: bug-followup at FreeBSD.org, yuri at tsoft.com
Cc:  
Subject: Re: bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR 
	environment variable to a location with at least 0 bytes
Date: Sun, 21 Mar 2010 16:35:58 -0700

 --0016367d6ff4e81c970482580a40
 Content-Type: text/plain; charset=ISO-8859-1
 
     Patch under test attached; will test and produce tests if
 successful. This proposed change does the following:
 
 1. Tacks on the application name that failed in an effort to provide
 improved logging; this is limited to lib/pen.c for the time being, but
 can and should be easily extended to other areas using variadic
 macros.
 2. Prevents a potential failure with realpath(3) in pkg_add(1).
 
 Cheers,
 -Garrett
 
 --0016367d6ff4e81c970482580a40
 Content-Type: application/octet-stream; name="bin.121165.diff"
 Content-Disposition: attachment; filename="bin.121165.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_g72hgp9r0
 
 PT09PSAvL2RlcG90L3Byb2plY3RzL3NvYzIwMDcvZ2Nvb3Blci1wa2dfaW5zdGFsbC1lbmhhbmNl
 bWVudHMtc2ltcGxpZmllZC91c3Iuc2Jpbi9wa2dfaW5zdGFsbC9hZGQvbWFpbi5jIzIgLSAvc2Ny
 YXRjaC9mcmVlYnNkL3BlcmZvcmNlL3BrZ19pbnN0YWxsLWVuaGFuY2VtZW50cy91c3Iuc2Jpbi9w
 a2dfaW5zdGFsbC9hZGQvbWFpbi5jID09PT0KQEAgLTUwLDYgKzUwLDggQEAKIAogY2hhcgkqKnBr
 Z3M7CiAKK2NoYXIJKnByb2duYW1lCT0gTlVMTDsKKwogc3RydWN0IHsKIAlpbnQgbG93dmVyOwkv
 KiBMb3dlc3QgdmVyc2lvbiBudW1iZXIgdG8gbWF0Y2ggKi8KIAlpbnQgaGl2ZXI7CS8qIEhpZ2hl
 c3QgdmVyc2lvbiBudW1iZXIgdG8gbWF0Y2ggKi8KQEAgLTEyOCw5ICsxMzAsMTIgQEAKICAgICBz
 dGF0aWMgY2hhciB0ZW1wcGFja2FnZXJvb3RbTUFYUEFUSExFTl07CiAgICAgc3RhdGljIGNoYXIg
 cGtnYWRkcGF0aFtNQVhQQVRITEVOXTsKIAotICAgIGlmICgqYXJndlswXSAhPSAnLycgJiYgc3Ry
 Y2hyKGFyZ3ZbMF0sICcvJykgIT0gTlVMTCkKLQlQa2dBZGRDbWQgPSByZWFscGF0aChhcmd2WzBd
 LCBwa2dhZGRwYXRoKTsKLSAgICBlbHNlCisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2VuYW1lKGFy
 Z3ZbMF0pKSA9PSBOVUxMKQorCWVycihFWElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOworICAgIGlm
 ICgqYXJndlswXSAhPSAnLycgJiYgc3RyY2hyKGFyZ3ZbMF0sICcvJykgIT0gTlVMTCkgeworCWlm
 ICgoUGtnQWRkQ21kID0gcmVhbHBhdGgoYXJndlswXSwgcGtnYWRkcGF0aCkpID09IE5VTEwpCisJ
 ICAgIGVycihFWElUX0ZBSUxVUkUsICJyZWFscGF0aCIpOworICAgIH0gZWxzZQogCVBrZ0FkZENt
 ZCA9IGFyZ3ZbMF07CiAKICAgICBzdGFydCA9IGFyZ3Y7Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9z
 b2MyMDA3L2djb29wZXItcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNi
 aW4vcGtnX2luc3RhbGwvY3JlYXRlL21haW4uYyMxIC0gL3NjcmF0Y2gvZnJlZWJzZC9wZXJmb3Jj
 ZS9wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMvdXNyLnNiaW4vcGtnX2luc3RhbGwvY3JlYXRlL21h
 aW4uYyA9PT09CkBAIC00NSw2ICs0NSw3IEBACiBpbnQJSGVscAkJPSBGQUxTRTsKIGVudW0gemlw
 cGVyCVppcHBlciAgPSBCWklQMjsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOwogCiBzdGF0aWMg
 dm9pZCB1c2FnZSh2b2lkKTsKIApAQCAtNzIsNiArNzMsOCBAQAogICAgIGludCBjaDsKICAgICBj
 aGFyICoqcGtncywgKipzdGFydCwgKnRtcDsKIAorICAgIGlmICgocHJvZ25hbWUgPSBiYXNlbmFt
 ZShhcmd2WzBdKSkgPT0gTlVMTCkKKwllcnIoRVhJVF9GQUlMVVJFLCAiYmFzZW5hbWUiKTsKICAg
 ICBwa2dzID0gc3RhcnQgPSBhcmd2OwogICAgIHdoaWxlICgoY2ggPSBnZXRvcHRfbG9uZyhhcmdj
 LCBhcmd2LCBvcHRzLCBsb25nb3B0cywgTlVMTCkpICE9IC0xKQogCXN3aXRjaChjaCkgewo9PT09
 IC8vZGVwb3QvcHJvamVjdHMvc29jMjAwNy9nY29vcGVyLXBrZ19pbnN0YWxsLWVuaGFuY2VtZW50
 cy1zaW1wbGlmaWVkL3Vzci5zYmluL3BrZ19pbnN0YWxsL2RlbGV0ZS9tYWluLmMjMSAtIC9zY3Jh
 dGNoL2ZyZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzL3Vzci5zYmluL3Br
 Z19pbnN0YWxsL2RlbGV0ZS9tYWluLmMgPT09PQpAQCAtMzcsNiArMzcsOCBAQAogQm9vbGVhbglS
 ZWN1cnNpdmUJPSBGQUxTRTsKIG1hdGNoX3QJTWF0Y2hUeXBlCT0gTUFUQ0hfR0xPQjsKIAorY2hh
 cgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKTsKIAogc3RhdGlj
 IGNoYXIgb3B0c1tdID0gImFkRGZHaGlucDpydnhYIjsKQEAgLTY3LDYgKzY5LDggQEAKICAgICBj
 b25zdCBjaGFyICp0bXA7CiAgICAgc3RydWN0IHN0YXQgc3RhdF9zOwogCisgICAgaWYgKChwcm9n
 bmFtZSA9IGJhc2VuYW1lKGFyZ3ZbMF0pKSA9PSBOVUxMKQorCWVycihFWElUX0ZBSUxVUkUsICJi
 YXNlbmFtZSIpOwogICAgIHBrZ3MgPSBzdGFydCA9IGFyZ3Y7CiAgICAgd2hpbGUgKChjaCA9IGdl
 dG9wdF9sb25nKGFyZ2MsIGFyZ3YsIG9wdHMsIGxvbmdvcHRzLCBOVUxMKSkgIT0gLTEpCiAJc3dp
 dGNoKGNoKSB7Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9zb2MyMDA3L2djb29wZXItcGtnX2luc3Rh
 bGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNiaW4vcGtnX2luc3RhbGwvaW5mby9tYWlu
 LmMjMSAtIC9zY3JhdGNoL2ZyZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRz
 L3Vzci5zYmluL3BrZ19pbnN0YWxsL2luZm8vbWFpbi5jID09PT0KQEAgLTM5LDYgKzM5LDggQEAK
 IEJvb2xlYW4gS2VlcFBhY2thZ2UJPSBGQUxTRTsKIHN0cnVjdCB3aGljaF9oZWFkICp3aGVhZDsK
 IAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2b2lkKTsKIAog
 c3RhdGljIGNoYXIgb3B0c1tdID0gImFiY2REZTpFZmdHaGlJamtLbDpMbW9POnBQcVFyUnN0OnZW
 Vzp4WCI7CkBAIC03Myw2ICs3NSw4IEBACiAJZXJyKDIsIE5VTEwpOwogICAgIFRBSUxRX0lOSVQo
 d2hlYWQpOwogCisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2VuYW1lKGFyZ3ZbMF0pKSA9PSBOVUxM
 KQorCWVycihFWElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOwogICAgIHBrZ3MgPSBzdGFydCA9IGFy
 Z3Y7CiAgICAgaWYgKGFyZ2MgPT0gMSkgewogCU1hdGNoVHlwZSA9IE1BVENIX0FMTDsKPT09PSAv
 L2RlcG90L3Byb2plY3RzL3NvYzIwMDcvZ2Nvb3Blci1wa2dfaW5zdGFsbC1lbmhhbmNlbWVudHMt
 c2ltcGxpZmllZC91c3Iuc2Jpbi9wa2dfaW5zdGFsbC9saWIvbGliLmgjMSAtIC9zY3JhdGNoL2Zy
 ZWVic2QvcGVyZm9yY2UvcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzL3Vzci5zYmluL3BrZ19pbnN0
 YWxsL2xpYi9saWIuaCA9PT09CkBAIC0zMCw2ICszMCw4IEBACiAjaW5jbHVkZSA8c3lzL3F1ZXVl
 Lmg+CiAjaW5jbHVkZSA8Y3R5cGUuaD4KICNpbmNsdWRlIDxkaXJlbnQuaD4KKyNpbmNsdWRlIDxl
 cnIuaD4KKyNpbmNsdWRlIDxsaWJnZW4uaD4KICNpbmNsdWRlIDxzdGRhcmcuaD4KICNpbmNsdWRl
 IDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgpAQCAtMjM5LDkgKzI0MSwxMCBAQAogaW50
 CQl2ZXJzaW9uX2NtcChjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKik7CiAKIC8qIEV4dGVybnMg
 Ki8KK2V4dGVybiBjaGFyCSpwcm9nbmFtZTsKIGV4dGVybiBCb29sZWFuCVF1aWV0OwogZXh0ZXJu
 IEJvb2xlYW4JRmFrZTsKLWV4dGVybiBCb29sZWFuICBGb3JjZTsKK2V4dGVybiBCb29sZWFuCUZv
 cmNlOwogZXh0ZXJuIGludAlBdXRvQW5zd2VyOwogZXh0ZXJuIGludAlWZXJib3NlOwogCj09PT0g
 Ly9kZXBvdC9wcm9qZWN0cy9zb2MyMDA3L2djb29wZXItcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRz
 LXNpbXBsaWZpZWQvdXNyLnNiaW4vcGtnX2luc3RhbGwvbGliL3Blbi5jIzMgLSAvc2NyYXRjaC9m
 cmVlYnNkL3BlcmZvcmNlL3BrZ19pbnN0YWxsLWVuaGFuY2VtZW50cy91c3Iuc2Jpbi9wa2dfaW5z
 dGFsbC9saWIvcGVuLmMgPT09PQpAQCAtNjIsMTAgKzYyLDExIEBACiAJY2xlYW51cCgwKTsKIAlo
 dW1hbml6ZV9udW1iZXIoaHVtYnVmLCBzaXplb2YgaHVtYnVmLCBzeiwgIiIsIEhOX0FVVE9TQ0FM
 RSwKIAkgICAgSE5fTk9TUEFDRSk7CisJLyogWFhYOiBNYWludGFpbiA4MCBjb2x1bW4gd2lkdGgg
 aW4gdGhlIGVycm9yIG1lc3NhZ2UuICovCiAJZXJyeCgyLAotIiVzOiBjYW4ndCBmaW5kIGVub3Vn
 aCB0ZW1wb3Jhcnkgc3BhY2UgdG8gZXh0cmFjdCB0aGUgZmlsZXMsIHBsZWFzZSBzZXQgeW91clxu
 IgotIlBLR19UTVBESVIgZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gYSBsb2NhdGlvbiB3aXRoIGF0
 IGxlYXN0ICVzIGJ5dGVzXG4iCi0iZnJlZSIsIF9fZnVuY19fLCBodW1idWYpOworCSAgICAiJXMu
 JXM6IG5vdCBlbm91Z2ggdGVtcG9yYXJ5IHNwYWNlIHRvIGV4dHJhY3QgdGhlIGZpbGVzOyBzZXQg
 UEtHX1RNUERJUiBpblxuIgorCSAgICAieW91ciBlbnZpcm9ubWVudCB0byBhIGxvY2F0aW9uIHdp
 dGggYXQgbGVhc3QgJXMgYnl0ZXMgZnJlZVxuIiwKKwkgICAgcHJvZ25hbWUsIF9fZnVuY19fLCBo
 dW1idWYpOwogCXJldHVybiBOVUxMOwogICAgIH0KICAgICByZXR1cm4gcGVuOwpAQCAtNzksNyAr
 ODAsNyBAQAogcHVzaFBlbihjb25zdCBjaGFyICpwZW4pCiB7CiAgICAgaWYgKCsrcGRlcHRoID09
 IE1BWF9TVEFDSykKLQllcnJ4KDIsICIlczogc3RhY2sgb3ZlcmZsb3cuXG4iLCBfX2Z1bmNfXyk7
 CisJZXJyeCgyLCAiJXM6IHN0YWNrIG92ZXJmbG93LlxuIiwgcHJvZ25hbWUsIF9fZnVuY19fKTsK
 ICAgICBwc3RhY2tbcGRlcHRoXSA9IHN0cmR1cChwZW4pOwogCiAgICAgcmV0dXJuIHBzdGFja1tw
 ZGVwdGhdOwpAQCAtMTI3LDkgKzEyOCwxMCBAQAogICAgIGlmIChtaW5fZnJlZShwZW4pIDwgc3op
 IHsKIAlybWRpcihwZW4pOwogCWNsZWFudXAoMCk7Ci0JZXJyeCgyLCAiJXM6IG5vdCBlbm91Z2gg
 ZnJlZSBzcGFjZSB0byBjcmVhdGUgJyVzJy5cbiIKKwllcnJ4KDIsICIlcy4lczogbm90IGVub3Vn
 aCBmcmVlIHNwYWNlIHRvIGNyZWF0ZSAnJXMnLlxuIgogCSAgICAgIlBsZWFzZSBzZXQgeW91ciBQ
 S0dfVE1QRElSIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGEgbG9jYXRpb25cbiIKLQkgICAgICJ3
 aXRoIG1vcmUgc3BhY2UgYW5kXG50cnkgdGhlIGNvbW1hbmQgYWdhaW4iLCBfX2Z1bmNfXywgcGVu
 KTsKKwkgICAgICJ3aXRoIG1vcmUgc3BhY2UgYW5kXG50cnkgdGhlIGNvbW1hbmQgYWdhaW4iLCBw
 cm9nbmFtZSwgX19mdW5jX18sCisJICAgICBwZW4pOwogICAgIH0KIAogICAgIGlmICghZ2V0Y3dk
 KGN3ZCwgRklMRU5BTUVfTUFYKSkgewpAQCAtMTM5LDcgKzE0MSw3IEBACiAKICAgICBpZiAoY2hk
 aXIocGVuKSA9PSBGQUlMKSB7CiAJY2xlYW51cCgwKTsKLQllcnJ4KDIsICIlczogY2FuJ3QgY2hk
 aXIgdG8gJyVzJyIsIF9fZnVuY19fLCBwZW4pOworCWVycngoMiwgIiVzOiVzOiBjYW4ndCBjaGRp
 ciB0byAnJXMnIiwgcHJvZ25hbWUsIF9fZnVuY19fLCBwZW4pOwogICAgIH0KIAogICAgIHN0cmNw
 eShQZW5Mb2NhdGlvbiwgcGVuKTsKQEAgLTE2MywxMSArMTY1LDExIEBACiAKICAgICBpZiAoY2hk
 aXIoUGVuTG9jYXRpb24pID09IEZBSUwpIHsKIAljbGVhbnVwKDApOwotCWVycngoMiwgIiVzOiBj
 YW4ndCBjaGRpciBiYWNrIHRvICclcyciLCBfX2Z1bmNfXywgUGVuTG9jYXRpb24pOworCWVycngo
 MiwgIiVzLiVzOiBjYW4ndCBjaGRpciBiYWNrIHRvICclcyciLCBwcm9nbmFtZSwgX19mdW5jX18s
 IFBlbkxvY2F0aW9uKTsKICAgICB9CiAKICAgICBpZiAobGVmdFswXSA9PSAnLycgJiYgdnN5c3Rl
 bSgiL2Jpbi9ybSAtcmYgJXMiLCBsZWZ0KSkKLQl3YXJueCgiY291bGRuJ3QgcmVtb3ZlIHRlbXBv
 cmFyeSBkaXIgJyVzJyIsIGxlZnQpOworCXdhcm54KCIlcy4lczogY291bGRuJ3QgcmVtb3ZlIHRl
 bXBvcmFyeSBkaXIgJyVzJyIsIHByb2duYW1lLCBfX2Z1bmNfXywgbGVmdCk7CiAgICAgc2lnbmFs
 KFNJR0lOVCwgb2xkc2lnKTsKIAogICAgIHJldHVybiAxOwpAQCAtMTc5LDcgKzE4MSw3IEBACiAg
 ICAgc3RydWN0IHN0YXRmcyBidWY7CiAKICAgICBpZiAoc3RhdGZzKHRtcGRpciwgJmJ1ZikgIT0g
 MCkgewotCXdhcm4oInN0YXRmcyIpOworCXdhcm4oIiVzLiVzOiBzdGF0ZnMiLCBwcm9nbmFtZSwg
 X19mdW5jX18pOwogCXJldHVybiAtMTsKICAgICB9CiAgICAgcmV0dXJuIChvZmZfdClidWYuZl9i
 YXZhaWwgKiAob2ZmX3QpYnVmLmZfYnNpemU7Cj09PT0gLy9kZXBvdC9wcm9qZWN0cy9zb2MyMDA3
 L2djb29wZXItcGtnX2luc3RhbGwtZW5oYW5jZW1lbnRzLXNpbXBsaWZpZWQvdXNyLnNiaW4vcGtn
 X2luc3RhbGwvdXBkYXRpbmcvbWFpbi5jIzEgLSAvc2NyYXRjaC9mcmVlYnNkL3BlcmZvcmNlL3Br
 Z19pbnN0YWxsLWVuaGFuY2VtZW50cy91c3Iuc2Jpbi9wa2dfaW5zdGFsbC91cGRhdGluZy9tYWlu
 LmMgPT09PQo9PT09IC8vZGVwb3QvcHJvamVjdHMvc29jMjAwNy9nY29vcGVyLXBrZ19pbnN0YWxs
 LWVuaGFuY2VtZW50cy1zaW1wbGlmaWVkL3Vzci5zYmluL3BrZ19pbnN0YWxsL3ZlcnNpb24vbWFp
 bi5jIzEgLSAvc2NyYXRjaC9mcmVlYnNkL3BlcmZvcmNlL3BrZ19pbnN0YWxsLWVuaGFuY2VtZW50
 cy91c3Iuc2Jpbi9wa2dfaW5zdGFsbC92ZXJzaW9uL21haW4uYyA9PT09CkBAIC0zNiw2ICszNiw4
 IEBACiBCb29sZWFuIFVzZUlOREVYT25seSA9IEZBTFNFOwogQm9vbGVhbiBTaG93T3JpZ2luID0g
 RkFMU0U7CiAKK2NoYXIJKnByb2duYW1lCT0gTlVMTDsKKwogc3RhdGljIHZvaWQgdXNhZ2Uodm9p
 ZCk7CiAKIHN0YXRpYyBjaGFyIG9wdHNbXSA9ICJkSWhsOkw6cXM6WHRUTzpvdiI7CkBAIC02Nyw2
 ICs2OSw4IEBACiAJY21wID0gdmVyc2lvbl9tYXRjaChhcmd2WzNdLCBhcmd2WzJdKTsKIAlleGl0
 KGNtcCA9PSAxID8gMCA6IDEpOwogICAgIH0KKyAgICBpZiAoKHByb2duYW1lID0gYmFzZW5hbWUo
 YXJndlswXSkpID09IE5VTEwpCisJZXJyKEVYSVRfRkFJTFVSRSwgImJhc2VuYW1lIik7CiAgICAg
 ZWxzZSB3aGlsZSAoKGNoID0gZ2V0b3B0X2xvbmcoYXJnYywgYXJndiwgb3B0cywgbG9uZ29wdHMs
 IE5VTEwpKSAhPSAtMSkgewogCXN3aXRjaChjaCkgewogCWNhc2UgJ3YnOgo=
 --0016367d6ff4e81c970482580a40--