bin/131861: [patch] mail(1) misses addresses when replying to all

Garrett Cooper yanefbsd at gmail.com
Tue Feb 16 19:05:37 UTC 2010


On Tue, Feb 16, 2010 at 9:10 AM, Pete French
<petefrench at ticketswitch.com> wrote:
> The following reply was made to PR bin/131861; it has been noted by GNATS.
>
> From: Pete French <petefrench at ticketswitch.com>
> To: bug-followup at FreeBSD.org
> Cc:
> Subject: Re: bin/131861: [patch] mail(1) misses addresses when replying to all
> Date: Tue, 16 Feb 2010 17:05:23 +0000
>
>  Looks like my last email messed up the formatting of the patch. here it is
>  with the tabs hopefully properly preserved!
>
>  --- usr.bin/mail/util.c.orig   2010-02-02 14:10:34.220987358 +0000
>  +++ usr.bin/mail/util.c        2010-02-16 09:31:08.924384302 +0000
>  @@ -496,10 +496,10 @@
>                                *cp2++ = ' ';
>                        }
>                        *cp2++ = c;
>  -                      if (c == ',' && *cp == ' ' && !gotlt) {
>  +                      if (c == ',' && (*cp == ' ' || *cp == '"') && !gotlt) {
>                                *cp2++ = ' ';
>  -                              while (*++cp == ' ')
>  -                                      ;
>  +                              while (*cp == ' ')
>  +                                      cp++;
>                                lastsp = 0;
>                                bufend = cp2;

    Two dumb questions:
    1. Why isn't this checking for '\0'?
    2. If there's a `"', shouldn't there be a terminating the end `"'
as well? It's a pretty blatant shell syntax error if that requirement
isn't met...
Thanks,
-Garrett


More information about the freebsd-bugs mailing list