kern/100513: Inconsistent definition of SMBus addresses in SMBus drivers

[Arthur Hartwig]

>Number:         100513
>Category:       kern
>Synopsis:       Inconsistent definition of SMBus addresses in SMBus drivers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 19 06:10:17 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Arthur Hartwig
>Release:        6.0
>Organization:
Nokia
>Environment:
FreeBSD xxx.nokia.com 6.0-RELEASE FreeBSD 6.0-RELEASE #3: Wed Mar  1 10:46:02 EST 2006     hartwig at xxx.nokia.com:/usr/src/sys/i386/compile/oz-net-10  i386

>Description:
The intpm driver takes the user specified address in the slave field of the smbcmd structure and or's in the read/write bit. At least some of the other smbus drivers take the user specified address, left shift it one bit then or in the read/write bit. Consequently, an application accessing an eeprom at address 0x55 on the SMBus needs to specify the slave field as 0xaa if intpm drives the SMBus while the application needs to specify the slave field as 0x55 if amdpm or ichsmb drives the  SMBus.

I think intpu should be changed to accept addresses in the same form as most of the other SMBus drivers.


>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: