bin/51655: savecore needs ${dumpdev} as an argument when it is set

[NAKAJI Hiroyuki]

>Number:         51655
>Category:       bin
>Synopsis:       savecore needs ${dumpdev} as an argument when it is set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 01 05:00:28 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     NAKAJI Hiroyuki
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD xa12.heimat.gr.jp 5.0-CURRENT FreeBSD 5.0-CURRENT #19: Thu May 1 10:50:26 JST 2003 root at xa12.heimat.gr.jp:/usr/obj/usr/src/sys/NAKAJI i386


>Description:
	/etc/rc.d/savecore is executed when ${dumpdev} is set in
/etc/rc.conf. And savecore is invoked from /etc/rc.d/savecore without
${dumpdev}. But no vmcore.0 is available after panic if ${dumpdev} is
not same as the first swap partition.

>How-To-Repeat:

In /etc/rc.conf two parameters are set:
dumpdev="/dev/ad1s1e"
dumpdir="/home/crash" # my /var is short

$ sudo savecore /home/crash 
checking for kernel dump on device /dev/da2s1b
mediasize = 209715200
sectorsize = 512
magic mismatch on last dump header on /dev/da2s1b
savecore: no dumps found

where /dev/da2s1b is the first swap partition set in /etc/fstab.

>Fix:

Index: savecore
===================================================================
RCS file: /net/pcat/home/ncvs/src/etc/rc.d/savecore,v
retrieving revision 1.3
diff -u -u -r1.3 savecore
--- savecore	6 Sep 2002 16:18:05 -0000	1.3
+++ savecore	1 May 2003 11:43:23 -0000
@@ -67,7 +67,7 @@
 savecore_start()
 {
 		echo "Checking for core dump..."
-		savecore ${savecore_flags} ${DUMPDIR}
+		savecore ${savecore_flags} ${DUMPDIR} ${dumpdev}
 }
 
 load_rc_config $name
>Release-Note:
>Audit-Trail:
>Unformatted: