[Differential] [Commented On] D2579: PCI support for Alpine platform from Annapurna Labs

emaste (Ed Maste) phabric-noreply at FreeBSD.org
Tue May 19 16:37:52 UTC 2015


emaste added inline comments.

INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_pci.c:414 See e.g. this discussion from LLVM's coding standards doc:
  http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
  We don't have this explicitly documented in FreeBSD, but in general prefer early returns.

REVISION DETAIL
  https://reviews.freebsd.org/D2579

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, imp, andrew, jhb, onwahe-gmail-com, meloun-miracle-cz, br, sson, loos, sbruno, rpaulo
Cc: emaste, freebsd-arm


More information about the freebsd-arm mailing list