[Differential] [Updated] D2579: PCI support for Alpine platform from Annapurna Labs

Tue May 19 16:30:54 UTC 2015

andrew added a reviewer: ARM.

INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_pci.c:247 So is it needed or is it always defined?
  sys/arm/annapurna/alpine/alpine_pci.c:414 You have:
    if (bus == 0) {
      ...
      return (0);
    } else {
      ...
    }

  The `else` case isn't needed as there is no way to get to past the if case. You could rewrite it as:
    if (bus == 0) {
      ...
      return (0);
    }
    ...

REVISION DETAIL
  https://reviews.freebsd.org/D2579

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, imp, andrew, jhb, onwahe-gmail-com, meloun-miracle-cz, br, sson, loos, sbruno, rpaulo
Cc: emaste, freebsd-arm