Large Capsicum patch for review.

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue Feb 26 12:12:33 UTC 2013


On Tue, Feb 26, 2013 at 11:43:12AM +0100, Dag-Erling Smørgrav wrote:
> Pawel Jakub Dawidek <pjd at FreeBSD.org> writes:
> > I use size_t as this is preferred type for size, but I don't need size_t
> > for iterator, because I know the value will never need more than 16
> > bits, so I use int as a more CPU-friendly type.
> 
> Using int as an iterator can lead to warnings about signedness mismatch
> in loop conditions etc., so you should at the very least use unsigned
> int. [...]

I use 'int' for 'ssize_t' and 'unsigned int' for 'size_t'.

> [...] Besides, size_t is equal to unsigned long on all platforms, so
> "CPU-friendly" is not a valid argument.

Is long more CPU-friendly than int?

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-arch/attachments/20130226/99be4fad/attachment.sig>


More information about the freebsd-arch mailing list