Large Capsicum patch for review.

Dag-Erling Smørgrav des at des.no
Tue Feb 26 10:43:15 UTC 2013


Pawel Jakub Dawidek <pjd at FreeBSD.org> writes:
> I use size_t as this is preferred type for size, but I don't need size_t
> for iterator, because I know the value will never need more than 16
> bits, so I use int as a more CPU-friendly type.

Using int as an iterator can lead to warnings about signedness mismatch
in loop conditions etc., so you should at the very least use unsigned
int.  Besides, size_t is equal to unsigned long on all platforms, so
"CPU-friendly" is not a valid argument.

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the freebsd-arch mailing list