[PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch

[Attilio Rao]

2010/2/25 Attilio Rao <attilio at freebsd.org>:
> 2010/2/25 M. Warner Losh <imp at bsdimp.com>:
>> In message: <3bbf2fe11002240718x5182aa93w5a00c657a0fba5f6 at mail.gmail.com>
>>            Attilio Rao <attilio at FreeBSD.org> writes:
>> : 2010/2/16 Kostik Belousov <kostikbel at gmail.com>:
>> : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote:
>> : >> The following patch:
>> : >> http://www.freebsd.org/~attilio/x86.diff
>> : >>
>> : >> starts the effort for having a shared sub-tree between amd64 and ia32.
>> : >> In this initial pass I putted the low-hanging fruits (bios/cpufreq)
>> : >> and what my customer was more interested in (isa/*) in order to
>> : >> kick-off the effort and, in the future, move gradually the code there.
>> : >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure
>> : >> more can be achieved easilly.
>> : >> There are few things to discuss. One, that I had not necessity to dig
>> : >> about still, is about how to organize headers (include/). Maybe some
>> : >> replication ala pc98 may be good.
>> : >>
>> : >> The patch is big but it is mostly added and removed files (look at the
>> : >> files.X in order to understand better how files movements happened).
>> : >>
>> : >> Hope to see comments and reviews.
>> : >
>> : > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv)
>> : > operation now, without a review, and post a diff that should be applied
>> : > to x86/ directory, as well as to build glue.
>> :
>> : I think that this patch juices out all the relevant part without noise:
>> : http://www.freebsd.org/~attilio/x86-2.diff
>>
>> Looks like you didn't add the required "sys/x86" files to files.pc98.
>
> There is still no-use for powerpc as it uses its own "isa"
> implementation it seems (it should be cbus).

s/powerpc/pc98, sorry.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein