bsd.apache.mk rewrite / cleanup

Philip M. Gollucci pgollucci at p6m7g8.com
Sun Aug 12 22:26:32 UTC 2012


Looks fine to me.  Why don't we just act on removing www/apache20 and
devel/apr0.
Then committing this is simpler
Then making www/apache24 is easier
Then moving APACHE_PORT to www/apache24 is 'easier' minus the MPM change.


On Sun, Aug 12, 2012 at 6:03 PM, Olli Hauer <ohauer at freebsd.org> wrote:

> Hi all,
>
> the bsd.apache.mk script has undergone a rewrite for better support of
> options NG.
>
> changed:
>  - make.conf pa-rams like WITH(OUT)_MODULES should be given in UPPER case.
>    Code to convert make.conf pa-rams to UPPER case is in place
>  - cleanup old constructs which are working in a sub-shell (@for ...
> ${GREP} ...)
>    the parts are replaced to use make logic.
>  - adjust apache20/apache22 ports for the new bsd.apache.mk.
>
> The bsd.apache.mk file should be touched again to support options NG in
> apache2x
> but those changes are only a view lines.
>
> I want to keep make.conf support the same way it works now even if apache22
> is rewritten with options NG support. This means against new options NG
> logic
> the make.conf has priority over options set by "make config" (old
> behavior).
> To give make.conf and command line pa-rams a higher priority is needed for
> static and other special builds.
>
> I've done endless tests with the rewritten bsd.apache.mk and have not
> found any
> backward incompatible issues (except if we remove the UPPERCASE convert
> part)
>
> There is additional room for more cleanup, some comments are in the patch
> (MFC TODO).
>
> For anyone interested in review before I commit the patches
>
> http://people.freebsd.org/~ohauer/diffs/apache/bsd.apache.mk_rewrite_2012-08-12.txt
>
> --
> olli
> _______________________________________________
> freebsd-apache at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-apache
> To unsubscribe, send any mail to "freebsd-apache-unsubscribe at freebsd.org"
>



-- 
---------------------------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Director Operations,      Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.


More information about the freebsd-apache mailing list