amd64/179376: xhci ehci irq storm

Konstantin Belousov kostikbel at gmail.com
Thu Jun 13 21:07:57 UTC 2013


On Thu, Jun 13, 2013 at 10:18:30AM -0400, John Baldwin wrote:
> On Tuesday, June 11, 2013 1:48:22 pm Konstantin Belousov wrote:
> > +	count = pci_msi_count(self);
> > +	if (count >= 1) {
> > +		if (count > 1)
> > +			count = 1;
> 
> You can just drop the if and always do the assignment here, yes?
> (Minor nit I know, and the original patch is fine for testing)

The comparision is useless, I removed it in my repo, thank you.

I remember somebody complained that xhci(4) cannot attach on the
Macs with the diagnostic about missing PRT entry for routing the
legacy interrupt.  As if Apple does not care about proper legacy
routing.  Hopefully, use of MSI-X would help there too.

Here is it:
http://lists.freebsd.org/pipermail/freebsd-current/2013-February/039595.html
http://people.freebsd.org/~dchagin/macbookpro/dmesg.generic.HEAD.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-amd64/attachments/20130614/e590a083/attachment.sig>


More information about the freebsd-amd64 mailing list