amd64/179376: xhci ehci irq storm

John Baldwin jhb at freebsd.org
Thu Jun 13 20:23:27 UTC 2013


On Tuesday, June 11, 2013 1:48:22 pm Konstantin Belousov wrote:
> --- a/sys/dev/usb/controller/xhci_pci.c
> +++ b/sys/dev/usb/controller/xhci_pci.c
> @@ -171,11 +170,22 @@ xhci_pci_attach(device_t self)
>  
>  	usb_callout_init_mtx(&sc->sc_callout, &sc->sc_bus.bus_mtx, 0);
>  
> -	rid = 0;
> -	sc->sc_irq_res = bus_alloc_resource_any(self, SYS_RES_IRQ, &rid,
> -	    RF_SHAREABLE | RF_ACTIVE);
> +	sc->sc_irq_rid = 0;
> +	count = pci_msi_count(self);
> +	if (count >= 1) {
> +		if (count > 1)
> +			count = 1;

You can just drop the if and always do the assignment here, yes?  (Minor nit I 
know, and the original patch is fine for testing)

-- 
John Baldwin


More information about the freebsd-amd64 mailing list