git: af366d353b84 - main - amd64: implement strlen in assembly

[Mateusz Guzik]

On 2/9/21, Jessica Clarke <jrtc27 at freebsd.org> wrote:
> Here's your review after reading through it for <5 minutes today:
>
> On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg at FreeBSD.org> wrote:
>> +	leaq	(%r11,%r8),%rcx
>> +	notq	%r11
>> +	andq	%r11,%rcx
>> +	andq	%r9,%rcx
>> ...
>> +	leaq	(%r11,%r8),%rcx
>> +	notq	%r11
>> +	andq	%rcx,%r11
>
> These look the wrong way round (but you got it the right way round
> above).
>

Indeed, solid brainfart. Interesting this still passed the test suite.
Thank you for noting this.

However, your response does not really address any of the points I
raised in my e-mail.

>> +	andq	%r9,%rcx
>
> Jess
>
>


-- 
Mateusz Guzik <mjguzik gmail.com>