git: af366d353b84 - main - amd64: implement strlen in assembly

Jessica Clarke jrtc27 at freebsd.org
Tue Feb 9 15:37:49 UTC 2021


Here's your review after reading through it for <5 minutes today:

On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg at FreeBSD.org> wrote:
> +	leaq	(%r11,%r8),%rcx
> +	notq	%r11
> +	andq	%r11,%rcx
> +	andq	%r9,%rcx
> ...
> +	leaq	(%r11,%r8),%rcx
> +	notq	%r11
> +	andq	%rcx,%r11

These look the wrong way round (but you got it the right way round
above).

> +	andq	%r9,%rcx

Jess



More information about the dev-commits-src-all mailing list