cvs commit: src/sys/netgraph/netflow ng_netflow.c

Alexander Motin mav at
Sat Feb 2 13:31:18 PST 2008

Gleb Smirnoff пишет:
>   you should have asked me for review before committing! This is
> not a bug, this is a feature. This was quite clear from the comments,
> that you removed:
> -       /* if export hook disconnected stop running expire(). */
>   This is intended behavior. We must not lose information unless
> user explicitly wants to lose information. In the latter case
> he will connect ng_hole(4) node to the "export" hook. But we must
> not lose information if user runs some script that swaps receiving
> node on the "export" hook.
>   Please backout this change!

Expire process was not depending completely on connected hook even 
before this commit. For example, every TCP session closing forces some 
data export. So even with export hook disconnected some data still will 
be lost and not just lost, but it was leading to memory leak which I 
have fixed with other commit.

So if you insist that it was a feature then sorry. Then it should be 
documented and fixed to work correctly. But as soon as nobody notice 
that memory leak, probably nobody uses this feature actively.

Alexander Motin

More information about the cvs-src mailing list