cvs commit: src/sys/netgraph/netflow ng_netflow.c

Gleb Smirnoff glebius at
Sat Feb 2 12:50:31 PST 2008


  you should have asked me for review before committing! This is
not a bug, this is a feature. This was quite clear from the comments,
that you removed:

-       /* if export hook disconnected stop running expire(). */

  This is intended behavior. We must not lose information unless
user explicitly wants to lose information. In the latter case
he will connect ng_hole(4) node to the "export" hook. But we must
not lose information if user runs some script that swaps receiving
node on the "export" hook.

  Please backout this change!

  I'm sorry that have seen it only after it hit RELENG_6 and RELENG_7
:( But that's your fault that you haven't asked me for review.

P.S. I'm closing the PR.

On Sun, Jan 27, 2008 at 03:01:16PM +0000, Alexander Motin wrote:
A> mav         2008-01-27 15:01:16 UTC
A>   FreeBSD src repository
A>   Modified files:
A>     sys/netgraph/netflow ng_netflow.c 
A>   Log:
A>   Run expire even without export hook connected.
A>   PR:     kern/119839
A>   Revision  Changes    Path
A>   1.15      +4 -8      src/sys/netgraph/netflow/ng_netflow.c
A> _______________________________________________
A> cvs-all at mailing list
A> To unsubscribe, send any mail to "cvs-all-unsubscribe at"

Totus tuus, Glebius.

More information about the cvs-src mailing list