cvs commit: src/sys/net if_vlan.c

Gleb Smirnoff glebius at
Fri Sep 16 05:37:31 PDT 2005

On Fri, Sep 16, 2005 at 04:34:21PM +0400, Yar Tikhiy wrote:
Y> On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote:
Y> > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote:
Y> > Y> yar         2005-09-16 11:44:43 UTC
Y> > Y> 
Y> > Y>   FreeBSD src repository
Y> > Y> 
Y> > Y>   Modified files:
Y> > Y>     sys/net              if_vlan.c 
Y> > Y>   Log:
Y> > Y>   Test the new M_VLANTAG packet flag before calling
Y> > Y>   m_tag_locate().  This adds little overhead of a simple
Y> > Y>   bitwise operation in case hardware VLAN acceleration
Y> > Y>   is on, yet saves the more expensive function call if
Y> > Y>   the acceleration is off.
Y> > Y>   
Y> > Y>   Reviewed by:    ru, glebius
Y> > Y>   X-MFC-after:    6.0
Y> >      ^^^^^^^^^^^^^^^^^^^
Y> > 			Why?
Y> 'Cause it's more about code consistency than stability, or performance,
Y> or features.  So I'd rather not bother re@ with this when they are
Y> being flooded with really important bugfixes.  It shouldn't be the
Y> extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;)

Not a bottleneck, but a significant processing addon for every
inbound packet.

If you don't mind I will request MFC from re@ after some testing.

Totus tuus, Glebius.

More information about the cvs-src mailing list