cvs commit: src/sys/net if_vlan.c

Yar Tikhiy yar at
Fri Sep 16 05:34:28 PDT 2005

On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote:
> On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote:
> Y> yar         2005-09-16 11:44:43 UTC
> Y> 
> Y>   FreeBSD src repository
> Y> 
> Y>   Modified files:
> Y>     sys/net              if_vlan.c 
> Y>   Log:
> Y>   Test the new M_VLANTAG packet flag before calling
> Y>   m_tag_locate().  This adds little overhead of a simple
> Y>   bitwise operation in case hardware VLAN acceleration
> Y>   is on, yet saves the more expensive function call if
> Y>   the acceleration is off.
> Y>   
> Y>   Reviewed by:    ru, glebius
> Y>   X-MFC-after:    6.0
>      ^^^^^^^^^^^^^^^^^^^
> 			Why?

'Cause it's more about code consistency than stability, or performance,
or features.  So I'd rather not bother re@ with this when they are
being flooded with really important bugfixes.  It shouldn't be the
extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;)


More information about the cvs-src mailing list