cvs commit: src/sys/net bridge.c

Mike Silbersack silby at silby.com
Mon Jul 4 05:59:31 GMT 2005


On Mon, 4 Jul 2005, Andrew Thompson wrote:

>> What's the route that a packet takes before it gets to the bridge?  If it
>> goes through ether_input, it would make sense to put the alignment there
>> when necessary.
>
> Both bridges tap their packets off near the end of ether_input(). Since
> we only need to check alignment when using pfil(9) and each bridge has
> its own knobs to control filtering, it seems best to leave it where it
> is at the moment.

Well, where it was at was the network drivers.  Since we know that em is 
the (only?) violator, you're arguing for the backout of your patch when 
you say "leave it where it is."

The other protocol stacks need aligned headers too, that's why I'm curious 
as to the bridge-specificness of this patch.

Mike "Silby" Silbersack


More information about the cvs-src mailing list