cvs commit: src/sys/net bridge.c

[Pyun YongHyeon]

On Mon, Jul 04, 2005 at 11:57:33AM +1200, Andrew Thompson wrote:
 > On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote:
 > > 
[...]
 > > 
 > > What's the route that a packet takes before it gets to the bridge?  If it 
 > > goes through ether_input, it would make sense to put the alignment there 
 > > when necessary.
 >  
 > Both bridges tap their packets off near the end of ether_input(). Since
 > we only need to check alignment when using pfil(9) and each bridge has
 > its own knobs to control filtering, it seems best to leave it where it
 > is at the moment.
 > 

No, all protocol handlers should check alignment too. Normal code
path without bridge/if_bridge would suffer from unaligned access.
But I think your patch wouldn't hurt existing code. :-)

-- 
Regards,
Pyun YongHyeon