cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c

Jake Burkholder jake at locore.ca
Mon Mar 31 17:02:04 PST 2003


Apparently, On Mon, Mar 31, 2003 at 04:37:15PM -0800,
	Nate Lawson said words to the effect of;

> On Mon, 31 Mar 2003, John Baldwin wrote:
> > On 31-Mar-2003 John Baldwin wrote:
> > > jhb         2003/03/31 12:22:00 PST
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/pci              if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c 
> > >                          if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c 
> > >   Log:
> > >   Add missing ()'s so that these drivers all compile again.
> > >   
> > >   Noticed by:     jake
> > >   Tested on:      i386 (compile)
> > 
> > Also, the pcn(4) driver still has some possibly bogus locking in
> > its probe routine.  Not sure if other drivers have locks in their
> > probe routines.
> 
> Thank you jhb and jake for fixing the KASSERT ()'s.  I had options
> INVARIANTS in my kernel so I'm not sure why this was not caught.  I was
> compiling them as modules so does INVARIANTS not enable KASSERT in
> modules?

It does not, option headers and not created automatically for modules.

Jake


More information about the cvs-src mailing list