cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c

Nate Lawson nate at
Mon Mar 31 16:37:16 PST 2003

On Mon, 31 Mar 2003, John Baldwin wrote:
> On 31-Mar-2003 John Baldwin wrote:
> > jhb         2003/03/31 12:22:00 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/pci              if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c 
> >                          if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c 
> >   Log:
> >   Add missing ()'s so that these drivers all compile again.
> >   
> >   Noticed by:     jake
> >   Tested on:      i386 (compile)
> Also, the pcn(4) driver still has some possibly bogus locking in
> its probe routine.  Not sure if other drivers have locks in their
> probe routines.

Thank you jhb and jake for fixing the KASSERT ()'s.  I had options
INVARIANTS in my kernel so I'm not sure why this was not caught.  I was
compiling them as modules so does INVARIANTS not enable KASSERT in

I'll do a quick grep for other bogus locking shortly.


More information about the cvs-src mailing list