cvs commit: www/en/cgi Makefile www/share/mk web.site.mk

[Hiroki Sato]

Hi Shaun,

Shaun Amott <shaun at FreeBSD.org> wrote
  in <20110721125514.GA57642 at charon.picobyte.net>:

sh> On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote:
sh> >  What do you think about the attached patch?  I did not notice these
sh> >  changes were submitted somewhere for review before the commit...
sh> >
sh> > -- Hiroki
sh>
sh> Hi Hiroki,
sh>
sh> The change was a temporary quick-fix to get the PR viewer working again.
sh> I am not intimately familiar with the doc build system, so wasn't sure
sh> about the best way to add the new subdirectories; but your way looks a
sh> lot cleaner to me.
sh>
sh> The script itself was made available some time ago on freebsd-www, so I
sh> considered it reviewed; I just didn't foresee the need for the other
sh> changes.

 Thank you for your reply.  I committed the patch just now and is
 checking if things go well.

 I do not think there is a serious problem with your commit, but next
 time when you have to change our www/doc build infrastructure, please
 submit a whole patch including that change to -doc at .  As you know it
 is (unnecessarily) complex and breaking the build prevents
 www.freebsd.org from updating.  I and other doc folks are willing to
 review it.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20110725/a3ffff62/attachment.pgp